prov/efa: Use endpoint->peer hashmap at the AV level#11636
Merged
sunkuamzn merged 1 commit intoofiwg:mainfrom Dec 16, 2025
Merged
prov/efa: Use endpoint->peer hashmap at the AV level#11636sunkuamzn merged 1 commit intoofiwg:mainfrom
sunkuamzn merged 1 commit intoofiwg:mainfrom
Conversation
Contributor
Author
|
bot:aws:retest |
1 similar comment
Contributor
|
bot:aws:retest |
sunkuamzn
force-pushed
the
multi-ep-av-hash
branch
3 times, most recently
from
f8ca132 to
4a46b73
Compare
shijin-aws
reviewed
Dec 15, 2025
Contributor
shijin-aws
left a comment
shijin-aws
left a comment
There was a problem hiding this comment.
Overall LGTM, thank you!
An fi_addr->peer hashmap at the endpoint level grows with the number of peers. An endpoint->peer hashmap grows with the number of endpoints - which would be better for applications that create many peers but few endpoints per AV e.g. MPI applications which only create a single endpoint per AV. Signed-off-by: Sai Sunku <[email protected]>
sunkuamzn
force-pushed
the
multi-ep-av-hash
branch
from
4a46b73 to
70e3cc6
Compare
Contributor
Author
|
@j-xiong @aingerson did the vcxproj file break Intel CI? |
Contributor
|
@sunkuamzn No, we don't do any windows testing in our CI. It was a random system availability timeout. You can ignore |
aingerson
approved these changes
Dec 16, 2025
shijin-aws
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An fi_addr->peer hashmap at the endpoint level grows with the number of peers. An endpoint->peer hashmap grows with the number of endpoints - which would be better for applications that create many peers but few endpoints per AV e.g. MPI applications which
only create a single endpoint per AV.